Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disposing of tasks scheduled on VirtualTimeScheduler #3097

Merged

Conversation

mdindoffer
Copy link
Contributor

Enables unit tests to track the execution state of tasks when using virtual time.

Fixes #3088

Enables unit tests to track the execution state of tasks when using virtual time.

Fixes reactor#3088
@mdindoffer mdindoffer requested a review from a team as a code owner June 30, 2022 11:45
@simonbasle simonbasle added type/enhancement A general enhancement area/reactor-test This belongs to the reactor-test module labels Jun 30, 2022
@simonbasle simonbasle added this to the 3.4.20 milestone Jun 30, 2022
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ! raising one question and associated need for documentation but this is looking good

@simonbasle simonbasle merged commit 7803a34 into reactor:3.4.x Jul 1, 2022
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

simonbasle added a commit that referenced this pull request Jul 1, 2022
@mdindoffer mdindoffer deleted the 3088-dispose_in_virtual_time_scheduler branch July 1, 2022 08:46
simonbasle pushed a commit that referenced this pull request Jul 1, 2022
This commit implements additional read capability to ContextView:
internal iteration via a `forEach` method which takes a `BiConsumer`.

This produces less garbage than the `stream()` one, which has to
create `Map.Entry` instances on top of the `Stream` itself for the
field-based implementations.

Fixes #3097.
@simonbasle
Copy link
Member

NB: This PR is wrongly referenced by commit 74444d4 (Add forEach method to ContextView and subclasses (#3092)) instead of #3094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reactor-test This belongs to the reactor-test module type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants