Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing default impl for Context::forEach #3101

Merged
merged 2 commits into from Jul 1, 2022
Merged

Introducing default impl for Context::forEach #3101

merged 2 commits into from Jul 1, 2022

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Jul 1, 2022

No description provided.

@chemicL chemicL requested a review from a team as a code owner July 1, 2022 12:28
@chemicL chemicL self-assigned this Jul 1, 2022
pderop
pderop approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemicL chemicL linked an issue Jul 1, 2022 that may be closed by this pull request
Add forEach to ContextView #3094
Closed
@simonbasle simonbasle added type/enhancement A general enhancement area/context This issue is related to the Context labels Jul 1, 2022
@simonbasle simonbasle added this to the 3.4.20 milestone Jul 1, 2022
@simonbasle simonbasle changed the title Introducing default impl for Context::forEach addressing #3094 Introducing default impl for Context::forEach Jul 1, 2022
@simonbasle simonbasle merged commit 3cfd0a7 into 3.4.x Jul 1, 2022
@simonbasle simonbasle deleted the 3080-contextApiMapAccessorDefault branch July 1, 2022 13:43
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

simonbasle added a commit that referenced this pull request Jul 1, 2022
@simonbasle
Merge #3101 into 3.5.0-M4
c728898 
conflict in japicmp exclusions, fixed by adding the new exclusion to the
bigger list present in main.
chemicL added a commit that referenced this pull request Jul 5, 2022
@chemicL
Merge #3101 into 3.5.0-M4
82fe0e1
@chemicL
Copy link
Member Author

chemicL commented Jul 5, 2022

This PR was erroneously referred by the commit 82fe0e1 -> please see #3103 if following that reference and looking for the correct PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees

@chemicL chemicL

Labels
area/context This issue is related to the Context type/enhancement A general enhancement
Projects
None yet
Milestone
3.4.20
Development

Successfully merging this pull request may close these issues.

Add forEach to ContextView
4 participants
@chemicL @reactorbot @pderop @simonbasle