Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Context::putAllMap #3102

Merged
merged 3 commits into from Jul 5, 2022
Merged

Introducing Context::putAllMap #3102

merged 3 commits into from Jul 5, 2022

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Jul 4, 2022

New method for easier write capability to Context when the user
is interacting with a generic Map instead of a Context and wants
all values to be added without creating an additional ContextView holder.

Resolves #3080

New method for easier write capability to `Context` when the user
is interacting with a generic `Map` instead of a `Context` and wants
all values to be added without creating an additional `ContextView` holder.

Resolves #3080
@chemicL chemicL requested a review from a team as a code owner July 4, 2022 11:55
@chemicL chemicL self-assigned this Jul 4, 2022
@@ -283,6 +280,20 @@ default Context putAll(ContextView other) {
return newContext;
}

default Context putAllMap(Map<?, ?> from) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add javadoc shortly.

@chemicL chemicL changed the base branch from main to 3.4.x July 4, 2022 13:38
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@simonbasle simonbasle added this to the 3.4.20 milestone Jul 4, 2022
@simonbasle simonbasle added the type/enhancement A general enhancement label Jul 4, 2022
@chemicL chemicL merged commit a776230 into 3.4.x Jul 5, 2022
@reactorbot
Copy link

@chemicL this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@chemicL chemicL deleted the 3080-contextApiPutAllMap branch July 5, 2022 10:00
chemicL added a commit that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Context API for writing from a Map
3 participants