Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate cancel signal on Mono to wrapped CompletableFuture #3138

Closed
rstoyanchev opened this issue Aug 4, 2022 · 3 comments · Fixed by #3146
Closed

Propagate cancel signal on Mono to wrapped CompletableFuture #3138

rstoyanchev opened this issue Aug 4, 2022 · 3 comments · Fixed by #3146
Assignees
@OlegDokuka
Labels
type/enhancement A general enhancement
Milestone
3.4.23

Comments

@rstoyanchev
Copy link
Contributor

Currently, Mono#fromFuture uses MonoCompletionStage, and CompletionStage does not have a cancel method. As a result, even if the Mono is cancelled, the future is never made aware of it.
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Aug 4, 2022
@rstoyanchev rstoyanchev mentioned this issue Aug 4, 2022
Open
@OlegDokuka
Copy link
Contributor

OlegDokuka commented Aug 4, 2022 •
edited

@rstoyanchev hah! it is already fixed in 3.5.x by #3081 (https://github.com/reactor/reactor-core/pull/3081/files#diff-e815d2e7a55f9f17006048ff085897e713143567345688c33e9d64b19f911f06R149). Do we need that backported into 3.4?

@rstoyanchev
Copy link
Contributor Author

Nice 👍 ! Yes please, a targeted backport of the cancellation propagation to CompletableFuture would be great indeed. The above linked issue is with Spring for GraphQL 1.0 and Reactor 3.4.x so that would help there.

@OlegDokuka OlegDokuka mentioned this issue Aug 10, 2022
Merged
@OlegDokuka OlegDokuka added type/enhancement A general enhancement and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Aug 10, 2022
@OlegDokuka OlegDokuka added this to the 3.4.23 milestone Aug 10, 2022
@OlegDokuka
Copy link
Contributor

closed with #3146

@He-Pin He-Pin mentioned this issue Sep 26, 2022
Open
@rohitrajwani rohitrajwani mentioned this issue Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegDokuka OlegDokuka

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
3.4.23
Development

Successfully merging a pull request may close this issue.

adds cancellation of the source future support reactor/reactor-core
3 participants
@rstoyanchev @OlegDokuka @reactorbot