Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refguide: Remove mention of discouraged subscribe variant #3141

Merged
merged 1 commit into from Aug 8, 2022

Conversation

simonbasle
Copy link
Member

This commit removes the mention of the subscribe variant that takes a
Consumer from the reference guide.
This method is deprecated in order to discourage it, as it is easy to
misuse it and cause hanging when no request is explicitly made by
the Consumer.

Fixes #3090.

@simonbasle simonbasle requested a review from a team as a code owner August 8, 2022 10:07
@simonbasle simonbasle added this to the 3.4.22 milestone Aug 8, 2022
@simonbasle simonbasle added the type/documentation A documentation update label Aug 8, 2022
@simonbasle simonbasle self-assigned this Aug 8, 2022
This commit removes the mention of the subscribe variant that takes a
Consumer<Subscription> from the reference guide.
This method is deprecated in order to discourage it, as it is easy to
misuse it and cause hanging when no request is explicitly made by
the Consumer.

Fixes #3090.
@simonbasle simonbasle force-pushed the 3090-removePlainSubscribeFromRefGuide branch from f8038a5 to 6625dbf Compare August 8, 2022 16:12
@simonbasle simonbasle merged commit be2b379 into 3.4.x Aug 8, 2022
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

simonbasle added a commit that referenced this pull request Aug 8, 2022
@simonbasle simonbasle deleted the 3090-removePlainSubscribeFromRefGuide branch August 8, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants