Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler.isDisposed() only true for disposed instances #3243

Merged
merged 1 commit into from Oct 21, 2022

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Oct 21, 2022

Some schedulers for optimization purposes started in a state which was considered as disposed (Scheduler#isDisposed()). This change affects only BoundedElasticScheduler as it was the last one which behaved this way.
This is a change of behavior, however one which was not documented.

Some schedulers for optimization purposes started in a state
which was considered as disposed (Scheduler#isDisposed()).
This change affects only BoundedElasticScheduler as it was
the last one which behaved this way.
This is a change of behavior, however one which was not documented.
@chemicL chemicL added the warn/behavior-change Breaking change of publicly advertised behavior label Oct 21, 2022
@chemicL chemicL added this to the 3.5.0 planning milestone Oct 21, 2022
@chemicL chemicL requested a review from a team as a code owner October 21, 2022 14:40
@chemicL chemicL self-assigned this Oct 21, 2022
@chemicL chemicL merged commit 593c68a into main Oct 21, 2022
@chemicL chemicL deleted the scheduler-isdisposed-only-disposed branch October 21, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants