Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ContextRegistry.getInstance() in tests #3244

Closed
simonbasle opened this issue Oct 21, 2022 · 2 comments
Closed

Use ContextRegistry.getInstance() in tests #3244

simonbasle opened this issue Oct 21, 2022 · 2 comments
Labels
area/observability type/enhancement A general enhancement
Milestone
3.5.0

Comments

@simonbasle
Copy link
Member

Since micrometer-metrics/context-propagation#53 one can remove ThreadLocalAccessors from the default context (this is available in snapshots post RC1).

Some of the more direct testing of context-propagation-enabled operators (contextCapture(), handle() and tap()) was previously not practical because this particular feature was missing.

If we can switch to snapshots before GA, it would be ideal to provide more test coverage using that feature. Notably, validating the snippets in the reference guide.
@simonbasle simonbasle added this to the 3.5.0 planning milestone Oct 21, 2022
@simonbasle
Copy link
Member Author

follow-up to #3180

@simonbasle simonbasle mentioned this issue Nov 4, 2022
Merged
@simonbasle
Copy link
Member Author

Closed by #3256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/observability type/enhancement A general enhancement
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
1 participant
@simonbasle