Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleans context for concat map for retry companion publisher #3262

Merged
merged 2 commits into from Nov 3, 2022

Conversation

OlegDokuka
Copy link
Contributor

closes #3253

Signed-off-by: Oleh Dokuka odokuka@vmware.com

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@OlegDokuka OlegDokuka added the type/bug A general bug label Nov 1, 2022
@OlegDokuka OlegDokuka added this to the 3.4.25 milestone Nov 1, 2022
@OlegDokuka OlegDokuka requested a review from a team as a code owner November 1, 2022 09:13
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting solution! it doesn't appear to affect the RetrySignal ability to expose a ContextView, at first glance at least. did you come across that part at all during development?

@OlegDokuka OlegDokuka merged commit b290bd8 into main Nov 3, 2022
//https://github.com/reactor/reactor-core/issues/3253
public void shouldWorkAsExpected() {
Mono.just(1)
.map(v -> { // ensure original context is propagated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by the comment? Is there any implicit validation of context preservation happening?

OlegDokuka added a commit that referenced this pull request Nov 3, 2022
chemicL pushed a commit that referenced this pull request Mar 7, 2023
@chemicL chemicL deleted the bugfix/#3253 branch April 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono and Flux with onErrorContinue hangs on network errors (thrown by Netty)
3 participants