From 63a701278410c5bc0207fa8ced5a20d7db754bd5 Mon Sep 17 00:00:00 2001 From: Pierre De Rop Date: Wed, 21 Sep 2022 18:23:20 +0200 Subject: [PATCH] Fixed leak reproduced by HttpServerTests.testIssue1978H2WithDelay. The Http2StreamBridgeServerHandler.channelRead method was still using old ReferenceCountUtil.release() instead of Resource.dispose() method. --- .../netty5/http/server/Http2StreamBridgeServerHandler.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reactor-netty5-http/src/main/java/reactor/netty5/http/server/Http2StreamBridgeServerHandler.java b/reactor-netty5-http/src/main/java/reactor/netty5/http/server/Http2StreamBridgeServerHandler.java index 93a9eb1b20..60efb6dd33 100644 --- a/reactor-netty5-http/src/main/java/reactor/netty5/http/server/Http2StreamBridgeServerHandler.java +++ b/reactor-netty5-http/src/main/java/reactor/netty5/http/server/Http2StreamBridgeServerHandler.java @@ -29,7 +29,7 @@ import io.netty5.handler.codec.http.LastHttpContent; import io.netty5.handler.codec.http2.Http2StreamFrameToHttpObjectCodec; import io.netty5.handler.ssl.SslHandler; -import io.netty5.util.ReferenceCountUtil; +import io.netty5.util.Resource; import io.netty5.util.concurrent.Future; import io.netty5.util.concurrent.FutureContextListener; import reactor.core.publisher.Mono; @@ -125,7 +125,7 @@ else if (!pendingResponse) { HttpServerOperations.log.debug(format(ctx.channel(), "Dropped HTTP content, " + "since response has been sent already: {}"), msg); } - ReferenceCountUtil.release(msg); + Resource.dispose(msg); ctx.read(); return; }