Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event loop task duration tracking #1433

Open
osi opened this issue Dec 15, 2020 · 2 comments
Open

Event loop task duration tracking #1433

osi opened this issue Dec 15, 2020 · 2 comments
Labels
type/enhancement A general enhancement
Milestone

Comments

@osi
Copy link

osi commented Dec 15, 2020

Similar to #1398, it would be nice to be able to track the duration of event loop tasks.

Reactor is able to do this for its schedulers via Schedulers.enableMetrics.

Additionally, it would be nice to set a threshold for the duration of any given task, and be able to log an event with details about that task (for identifying specific instances in the metrics)

@osi osi added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Dec 15, 2020
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Dec 16, 2020
@violetagg violetagg added this to the 1.0.x Backlog milestone Dec 16, 2020
@kevinten10
Copy link

Full monitoring may cause redundant information and excessive performance loss.

Is it more reasonable to perform sampling of this part of the function?

like: sample(() -> Schedulers.enableMetrics, (Predicate) () -> { /* Trigger threshold */ });

@osi
Copy link
Author

osi commented Dec 18, 2020

Sampling may be fine. My goal is to identify work taking place on an event loop thread that is effectively blocking the loop due to how long it takes. (even if the work is fully non-blocking).

@pderop pderop self-assigned this Dec 8, 2021
@violetagg violetagg modified the milestones: 1.0.x Backlog, 1.1.x Backlog Apr 13, 2022
@violetagg violetagg modified the milestones: 1.1.x Backlog, 2.0.x Backlog Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants