Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException on connectionInfo.getScheme() in HttpServerOperations for Unix Domain Sockets #1434

Closed
anupam-contaque opened this issue Dec 17, 2020 · 1 comment · Fixed by #1436
Closed

NullPointerException on connectionInfo.getScheme() in HttpServerOperations for Unix Domain Sockets #1434

anupam-contaque opened this issue Dec 17, 2020 · 1 comment · Fixed by #1436
Assignees
@violetagg
Labels
type/bug A general bug
Milestone
1.0.3

Comments

@anupam-contaque
Copy link

ConnectionInfo in HttpServerOperations is annotated as @Nullable but there isn't any null check before calling getScheme()

reactor-netty/reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java

Line 375 in 380a10a

return this.connectionInfo.getScheme();

See spring-projects/spring-boot#24529 (comment)
@anupam-contaque anupam-contaque changed the title NullPointerException on connectionInfo.getScheme() for Unix Domain Sockets NullPointerException on connectionInfo.getScheme() in HttpServerOperations for Unix Domain Sockets Dec 17, 2020
@violetagg violetagg linked a pull request Dec 17, 2020 that will close this issue
fix #1434 When UDS, the scheme is determined by SslHandler availability in the pipeline #1436
Merged
@violetagg violetagg mentioned this issue Dec 17, 2020
Merged
@violetagg violetagg self-assigned this Dec 17, 2020
@violetagg violetagg added this to the 1.0.3 milestone Dec 17, 2020
@violetagg
Copy link
Member

@anupam-contaque PTAL PR #1436

@violetagg violetagg added the type/bug A general bug label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.3
2 participants
@violetagg @anupam-contaque