Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise HttpMetricsHandlerTests#testServerConnectionsRecorder #2368

Closed
violetagg opened this issue Jul 8, 2022 · 3 comments · Fixed by #2391
Closed

Revise HttpMetricsHandlerTests#testServerConnectionsRecorder #2368

violetagg opened this issue Jul 8, 2022 · 3 comments · Fixed by #2391
Assignees
@pderop
Labels
type/bug A general bug
Milestone
1.0.22

Comments

@violetagg
Copy link
Member

This test is flaky and it is observed that it fails from time to time on the CI for all versions 1.0.x, 1.1.x, 2.0.x
@violetagg violetagg added the type/bug A general bug label Jul 8, 2022
@violetagg violetagg added this to the 1.0.x Backlog milestone Jul 8, 2022
@pderop pderop self-assigned this Jul 8, 2022
@pderop
Copy link
Member

pderop commented Jul 8, 2022

example of failing test (netty5 branch): https://github.com/reactor/reactor-netty/runs/7250727386?check_suite_focus=true

@pderop pderop modified the milestones: 1.0.x Backlog, 1.0.21 Jul 11, 2022
@violetagg violetagg modified the milestones: 1.0.21, 1.0.22 Jul 11, 2022
@violetagg
Copy link
Member Author

failure on 1.0.x publishing job https://github.com/reactor/reactor-netty/runs/7335349635?check_suite_focus=true#step:4:68

@pderop
Copy link
Member

pderop commented Jul 14, 2022

yes, same error on 1.0.x, I will fix soon on 1.0.x and then merge to main and netty5 branch.

@pderop pderop mentioned this issue Jul 18, 2022
Merged
@violetagg violetagg linked a pull request Jul 18, 2022 that will close this issue
Revise HttpMetricsHandlerTests and fix testServerConnectionsRecorder #2391
Merged
@pderop pderop closed this as completed in 115257b Aug 3, 2022
@pderop pderop mentioned this issue Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pderop pderop

Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.22
Development

Successfully merging a pull request may close this issue.

Revise HttpMetricsHandlerTests and fix testServerConnectionsRecorder pderop/reactor-netty
2 participants
@pderop @violetagg