Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HttpClientConfig#connectionProvider returns the original provider used to create HttpClient #2483

Merged
merged 1 commit into from Sep 15, 2022
Merged

Ensure HttpClientConfig#connectionProvider returns the original provider used to create HttpClient #2483

merged 1 commit into from Sep 15, 2022

Conversation

violetagg
Copy link
Member

Fixes #2462

@violetagg violetagg added the type/bug A general bug label Sep 14, 2022
@violetagg violetagg added this to the 1.0.24 milestone Sep 14, 2022
@violetagg violetagg requested a review from a team September 14, 2022 10:21
@violetagg violetagg linked an issue Sep 14, 2022 that may be closed by this pull request
Use HttpConnectionProvider mutate method #2462
Closed
@violetagg violetagg mentioned this pull request Sep 14, 2022
Closed
pderop
pderop approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangbongsoo
Copy link

yangbongsoo commented Sep 14, 2022 •
edited

@violetagg I have a few questions.
Before that, I'm not raising a question about your way.
I think it could be a better way because you know more about reactor-netty than I do.

I chose the method of minimizing the change and There are two things in HttpConnectionProvider, http1 and http2, so I thought it was right to consider both(#2468). Isn't this method rather simple? Let me know if there's anything I didn't think of. I want to learn.

@violetagg violetagg mentioned this pull request Sep 14, 2022
Closed
@violetagg
Copy link
Member Author

@pderop @yangbongsoo Thanks for the review!

@violetagg violetagg merged commit b4648c8 into 1.0.x Sep 15, 2022
@violetagg violetagg deleted the issue-2462 branch September 15, 2022 13:25
violetagg added a commit that referenced this pull request Sep 15, 2022
@violetagg
Merge #2483 into 1.1.0-RC1
83c594f
violetagg added a commit that referenced this pull request Sep 15, 2022
@violetagg
Merge #2483 into 2.0.0-M2
c35f24f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

@yangbongsoo yangbongsoo yangbongsoo approved these changes

Assignees
No one assigned
Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.24
Development

Successfully merging this pull request may close these issues.

Use HttpConnectionProvider mutate method
3 participants
@violetagg @yangbongsoo @pderop