Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer the creation of the request/response object #2496

Merged
merged 1 commit into from Sep 21, 2022

Conversation

violetagg
Copy link
Member

If there is no subscription we may not need this object.

If there is no subscription we may not need this object.
@violetagg violetagg added the type/enhancement A general enhancement label Sep 21, 2022
@violetagg violetagg added this to the 1.0.24 milestone Sep 21, 2022
@violetagg violetagg requested a review from a team September 21, 2022 15:38
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 5a644f7 into 1.0.x Sep 21, 2022
@violetagg violetagg deleted the delay-creation-of-the-object branch September 21, 2022 16:45
violetagg added a commit that referenced this pull request Sep 21, 2022
violetagg added a commit that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants