Support HTTP errors 414 and 431 #2534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
414 is "uri too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/414 431 is "header too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/431 Old behavior was using 413 "request payload too large" which is specific to the content, not the first line or headers.
|
@yuzawa-san Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@yuzawa-san Thank you for signing the Contributor License Agreement! |
violetagg
approved these changes
Oct 7, 2022
|
@reactor/team PTAL |
simonbasle
approved these changes
Oct 10, 2022
|
@simonbasle @pderop Thanks for the review! |
violetagg
pushed a commit
that referenced
this pull request
Oct 10, 2022
414 is "uri too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/414 431 is "header too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/431 Old behaviour was using 413 "request payload too large" which is specific to the content, not the first line or headers.
violetagg
added a commit
that referenced
this pull request
Oct 10, 2022
violetagg
added a commit
that referenced
this pull request
Oct 10, 2022
|
@yuzawa-san Thanks for the PR! |
NiccoMlt
added a commit
to NiccoMlt/carapaceproxy
that referenced
this pull request
May 17, 2023
pv3nturi
added a commit
to diennea/carapaceproxy
that referenced
this pull request
May 23, 2023
* Bump reactor-netty to 2022.0.7 * fix flaky tests * test: fix MaxHeaderSizeTest See reactor/reactor-netty#2534 * test: fix ConnectionPoolTest * now we should expect Bad Request with capital R * also, minor refactor in some tests while trying to reproduce failings test: working on CacheContentLengthLimitTest * ci: add Surefire JUnit report collection apply some suggestions from #404 --------- Co-authored-by: paolo.venturi <paolo.venturi@diennea.com> Co-authored-by: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
414 is "uri too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/414 431 is "header too long" https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/431 Old behavior was using 413 "request payload too large" which is specific to the content, not the first line or headers.
I added this upstream to Netty a while ago, netty/netty#12084
vert.x seems to have upgraded their implementation in a similar manner