From 7c6be3e3215b9ec4f4e359f82bd902fe862b6cd2 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Wed, 27 Jul 2022 16:55:43 +0000 Subject: [PATCH 1/3] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- .../src/test/java/reactor/netty/ByteBufFluxTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java index 89d4478485..568b2f363c 100644 --- a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java +++ b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java @@ -139,9 +139,9 @@ void testFromPath() throws Exception { private static File createTemporaryDirectory() { try { - final File tempDir = File.createTempFile("ByteBufFluxTest", "", null); - assertThat(tempDir.delete()).isTrue(); - assertThat(tempDir.mkdir()).isTrue(); + final File tempDir = Files.createTempDirectory("ByteBufFluxTest").toFile(); + assertThat(true).isTrue(); + assertThat(true).isTrue(); return tempDir; } catch (Exception e) { From 48ad6ddca8e4312d132882400e78b6de19f9eff0 Mon Sep 17 00:00:00 2001 From: Violeta Georgieva Date: Thu, 28 Jul 2022 11:33:23 +0300 Subject: [PATCH 2/3] Update reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java --- .../src/test/java/reactor/netty/ByteBufFluxTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java index 568b2f363c..4aebf4d504 100644 --- a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java +++ b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java @@ -140,8 +140,6 @@ void testFromPath() throws Exception { private static File createTemporaryDirectory() { try { final File tempDir = Files.createTempDirectory("ByteBufFluxTest").toFile(); - assertThat(true).isTrue(); - assertThat(true).isTrue(); return tempDir; } catch (Exception e) { From 7647752b4070f5eeab5c7c0cb490d1cd664ed985 Mon Sep 17 00:00:00 2001 From: Violeta Georgieva Date: Thu, 28 Jul 2022 11:34:20 +0300 Subject: [PATCH 3/3] Update copyright end year --- .../src/test/java/reactor/netty/ByteBufFluxTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java index 4aebf4d504..5a8cb47b32 100644 --- a/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java +++ b/reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2021 VMware, Inc. or its affiliates, All Rights Reserved. + * Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.