From 87d28b63388f3bc296e24be8662e86b40d2ae986 Mon Sep 17 00:00:00 2001
From: Konstantin <kzimin@tizbi.com>
Date: Fri, 18 Oct 2019 17:14:04 +0300
Subject: [PATCH] Fixed a11y property error message (#1673)

* Fixed a11y propery error message

* Dropdown compare custom props with attrs test
---
 src/Dropdown.js                |  2 +-
 src/__tests__/Dropdown.spec.js | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/Dropdown.js b/src/Dropdown.js
index b5beb360d..a79e4ea09 100644
--- a/src/Dropdown.js
+++ b/src/Dropdown.js
@@ -206,7 +206,7 @@ class Dropdown extends React.Component {
       addonType,
       tag,
       ...attrs
-    } = omit(this.props, ['toggle', 'disabled', 'inNavbar']);
+    } = omit(this.props, ['toggle', 'disabled', 'inNavbar', 'a11y']);
 
     const Tag = tag || (nav ? 'li' : 'div');
 
diff --git a/src/__tests__/Dropdown.spec.js b/src/__tests__/Dropdown.spec.js
index b34b02a98..ecb1ff505 100644
--- a/src/__tests__/Dropdown.spec.js
+++ b/src/__tests__/Dropdown.spec.js
@@ -68,6 +68,22 @@ describe('Dropdown', () => {
   });
 
   describe('handleProps', () => {
+    it('should not pass custom props to html attrs', () => {
+      const wrapper = mount(
+        <Dropdown inNavbar a11y isOpen={isOpen} toggle={toggle}>
+          <DropdownToggle>Toggle</DropdownToggle>
+          <DropdownMenu>
+            <DropdownItem>Test</DropdownItem>
+          </DropdownMenu>
+        </Dropdown>
+      );
+
+      expect(wrapper.find('.dropdown').prop('inNavbar')).toBe(undefined);
+      expect(wrapper.find('.dropdown').prop('toggle')).toBe(undefined);
+      expect(wrapper.find('.dropdown').prop('a11y')).toBe(undefined);
+      expect(wrapper.find('.dropdown').prop('isOpen')).toBe(undefined);
+    });
+
     it('should be called on componentDidUpdate when isOpen changed', () => {
       jest.spyOn(Dropdown.prototype, 'componentDidUpdate');
       jest.spyOn(Dropdown.prototype, 'handleProps');