From 93973be4eb2ddf77f9da0d079bba7183d3bb8c0a Mon Sep 17 00:00:00 2001 From: Evan Sharp Date: Fri, 17 Jan 2020 14:19:34 -0500 Subject: [PATCH] Revert "fix(Collapse): add aria-expanded attribute " (#1759) This reverts commit 2fdf15a90927a1743f8cb1a5f161e67b4ee5a0e2. --- src/Collapse.js | 1 - src/__tests__/Collapse.spec.js | 8 -------- src/__tests__/UncontrolledCollapse.spec.js | 10 ---------- 3 files changed, 19 deletions(-) diff --git a/src/Collapse.js b/src/Collapse.js index af2146d20..9bac27e6d 100644 --- a/src/Collapse.js +++ b/src/Collapse.js @@ -127,7 +127,6 @@ class Collapse extends Component { style={{ ...childProps.style, ...style }} className={classes} ref={this.props.innerRef} - aria-expanded={isOpen ? 'true' : 'false'} > {children} diff --git a/src/__tests__/Collapse.spec.js b/src/__tests__/Collapse.spec.js index bc508860f..3000ffad9 100644 --- a/src/__tests__/Collapse.spec.js +++ b/src/__tests__/Collapse.spec.js @@ -122,12 +122,4 @@ describe('Collapse', () => { expect(wrapper.state('height')).toBe(null); wrapper.unmount(); }); - - it('should set aria-expanded', () => { - isOpen = false; - wrapper = mount(); - expect(wrapper.find('div').prop('aria-expanded')).toBe('false'); - toggle(); - expect(wrapper.find('div').prop('aria-expanded')).toBe('true'); - }); }); diff --git a/src/__tests__/UncontrolledCollapse.spec.js b/src/__tests__/UncontrolledCollapse.spec.js index 04c3fd667..dcd5e102f 100644 --- a/src/__tests__/UncontrolledCollapse.spec.js +++ b/src/__tests__/UncontrolledCollapse.spec.js @@ -95,14 +95,4 @@ describe('UncontrolledCollapse', () => { expect(UncontrolledCollapse.prototype.toggle.mock.calls.length).toBe(1); }); - - it('should set aria-expanded', () => { - const collapse = mount(Yo!); - - expect(collapse.find('div').prop('aria-expanded')).toBe('false'); - toggler.click(); - collapse.update(); - - expect(collapse.find('div').prop('aria-expanded')).toBe('true'); - }); });