Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Close Tooltip when clicking outside of it (useful when high hide delay set) #1079

Closed
juanmaguitar opened this issue Jun 16, 2018 · 2 comments
Closed

Feature: Close Tooltip when clicking outside of it (useful when high hide delay set) #1079

juanmaguitar opened this issue Jun 16, 2018 · 2 comments

Comments

@juanmaguitar
Copy link
Contributor

juanmaguitar commented Jun 16, 2018 •
edited

Issue description

  • components: Tooltip
  • reactstrap version 6.1.0

What is happening?

If the Tooltip is set with some delay on hide, clicking outside doesn't close it
https://codesandbox.io/s/j3lp8k5np9

What should be happening?

Clicking outside the tooltip should close it
@juanmaguitar juanmaguitar mentioned this issue Jun 16, 2018
Closed
@juanmaguitar juanmaguitar changed the title Bug: Closing the Tooltip when clicking outside is not working Feature: When delay hide set, closing outisde the Tooltip should close it Jun 16, 2018
@juanmaguitar juanmaguitar changed the title Feature: When delay hide set, closing outisde the Tooltip should close it Feature: When delay hide set, closing outisde the Tooltip should close it (desktop) Jun 16, 2018
@juanmaguitar juanmaguitar changed the title Feature: When delay hide set, closing outisde the Tooltip should close it (desktop) Feature: Close Tooltip when clicking outside of it (useful when high hide delay set) Jun 16, 2018
@TheSharpieOne
Copy link
Member

TheSharpieOne commented Jun 18, 2018 •
edited

This is not how bootstrap has implemented it. In order to mimic bootstrap as much as possible, we cannot have it close when clicked outside.

bootstrap: https://codepen.io/TheSharpieOne/pen/pKpzBj

If you feel this is an issue, please raise it with bootstrap. Once bootstrap changing it's implementation, reactstrap can do the same.

@juanmaguitar
Copy link
Contributor Author

Opened the issue on bootstrap → twbs/bootstrap#26719

@nathanbacon nathanbacon mentioned this issue Jun 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juanmaguitar @TheSharpieOne