New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Toast messages (Bootstrap 4.2.1) #1346
Comments
I might open a PR if I have enough time to get around to doing this. I'm guessing we would handle showing and hiding toast messages via state? |
I imagine they would work much like |
Would it be useful to use a library like react-timeago in the Toast example? Or just reference how you would implement it via a library? |
An example in the docs could be good, make sure when the package is installed, it's installed as a devDev. |
Any news with this new feature? Or just quick question, when will the docs for this feature (along with other new BS release like Switch and etc) that have been implemented be released? |
switch and spinner have already been released (a week ago) and the docs were updated when the PRs for those features were merged (switch is on the forms page with the custom inputs and spinner has its own page). |
I haven't had the chance to implement this yet, I've been quite busy with school. I'll open a PR once I get the first revision done. |
Oh ok, got it. Thanks everyone xD |
I started work on this in case @bpas247 hasn't yet started. Didn't want to step on toes, but I would love to see this out in the world: https://github.com/charlex/reactstrap/tree/toasts It's still a work in progress, but I could maybe use some suggestions on how to handle the little icon bug in the top left (and in general). Should it be a prop like <Toast>
<ToastHeader icon="warning">Reactstrap</ToastHeader>
<ToastBody>Lorem ipsum</ToastBody>
</Toast> Here is a screenshot of the in progress docs: https://user-images.githubusercontent.com/1542740/51679897-2eb69900-1fae-11e9-85eb-01a7ba9242de.png |
The way you're currently implementing the icon is what I had in mind originally, so definitely keep up the good work 👍 I'd suggest opening up a PR and labeling it as |
Good thinking @bpas247 . I'll open a PR now. |
Please add support for toast messages which were recently added in version 4.2.1:
https://getbootstrap.com/docs/4.2/components/toasts/
The text was updated successfully, but these errors were encountered: