feat(Popper): Add fade support for ToolTip and Popover (#363) #1364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first PR. I hope I'm doing everything right! This is to address issue #363.
Changes in this PR
fade={false}
in Tooltip/Popovertooltip show
) from any extra classNames as to apply these classes to the ReactPopper child component for display purposes, and the extra classes will be applied to the root Fade component. I was not sure if this is the intended behavior, or if the extra classNames should be applied to ReactPopper instead.fade={false}