Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination-links): added props for first and last. changed carets… #1410

Merged
merged 1 commit into from Feb 22, 2019
Merged

feat(pagination-links): added props for first and last. changed carets… #1410

merged 1 commit into from Feb 22, 2019

Conversation

GoPro16
Copy link
Member

@GoPro16 GoPro16 commented Feb 22, 2019

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Currently the next and previous props on the PaginationLink component have default carets that symbolize first and last. I added new props for first and last in order to have both features for navigating to any of these.

One change that is not breaking but does impact the view on the UI is the now the next and previous props are displaying single carets instead of double caret. I am not sure if this should be treated as a BREAKING CHANGE or not as its very minor in this case.

@GoPro16 GoPro16 changed the title fix(pagination-links): added props for first and last. changed carets… feat(pagination-links): added props for first and last. changed carets… Feb 22, 2019
@TheSharpieOne TheSharpieOne merged commit 70cfca2 into reactstrap:master Feb 22, 2019
@TheSharpieOne
Copy link
Member

Thanks!

Yes, it would be considered a breaking change as the output is now different. Any build which pulls in minor releases and has snapshot tests would potentially break if they were using previous and next before.

I think the next release was already queued up for a major anyways, just waiting on a few extra breaking changes to be completed and merged to group them together.

@GoPro16
Copy link
Member Author

GoPro16 commented Feb 22, 2019

Awesome sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants