fix(TooltipPopoverWrapper) Touch not opening popover on mobile (#1425) #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Popovers/Tooltips with trigger="click" or trigger="legacy", touches on mobile were triggering touchstart and then click, which caused them to open briefly and then immediately close. This removes the touchstart event handling to fix behaviour on mobile.
hsource
changed the title
michaelmulley
pushed a commit
to elsevier-research/reactstrap
that referenced
this pull request
Apr 4, 2019
…eactstrap#1426) For Popovers/Tooltips with trigger="click" or trigger="legacy", touches on mobile were triggering touchstart and then click, which caused them to open briefly and then immediately close. This removes the touchstart event handling to fix behaviour on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Popovers/Tooltips with trigger="click" or trigger="legacy", touches
on mobile were triggering touchstart and then click, which caused them
to open briefly and then immediately close. This removes the
touchstart event handling to fix behaviour on mobile.
#1425