Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Modal, Dropdown{*}, PopperContent, Tabs): go to React Async Rendering #1427

Merged
merged 5 commits into from Apr 3, 2019

Conversation

aakula-edmunds
Copy link
Contributor

The main purpose of the changes is to move forward to React Async Rendering.
The changes include:

  1. remove unsafe componentWillReceiveProps and componentWillUpdate in Modal.
  2. get rid of findDOMNode in Dropdown.
  3. replace legacy context with new Context API in DropdownItem, DropdownToggle, Dropdown, TabContent.
  4. upgrade react-popper to '1.3.3', and make the corresponding changes in PopperContent, DropdownItem, DropdownToggle, DropdownMenu, Dropdown.

BREAKING CHANGE: using new Context API, react-popper v. '1.3.3'

  • Bug fix
  • New feature
  • Refactoring: Update on React Async Rendering
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

aakula-edmunds and others added 5 commits March 5, 2019 14:46
…ync Rendering

The main purpose of the changes is to move forward to React Async Rendering.
The changes include:
1. remove unsafe componentWillReceiveProps and componentWillUpdate in Modal.
2. get rid of findDOMNode in Dropdown.
3. replace legacy context with new Context API in DropdownItem, DropdownToggle, Dropdown, TabContent.
4. upgrade react-popper to '1.3.3', and make the corresponding changes in  PopperContent, DropdownItem, DropdownToggle, DropdownMenu, Dropdown.

BREAKING CHANGE: using new Context API, react-popper v. '1.3.3'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants