Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): update condition to call setFocus in case open modal is… #1514

Merged

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented May 30, 2019

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

An unexpected case happened when I fixed the error in #1495, I reviewed and created this PR to update for that case.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jun 4, 2019

@virgofx Please review this PR, thank you very much!

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jun 25, 2019

@TheSharpieOne I think you should review this PR, thank you!

@TheSharpieOne TheSharpieOne merged commit ae6fe93 into reactstrap:master Jun 25, 2019
@lh0x00
Copy link
Contributor Author

lh0x00 commented Jun 25, 2019

@TheSharpieOne thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants