Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DropdownMenu): Allow positionFixed prop to be passed through #1538

Merged

Conversation

ccummings
Copy link
Contributor

Allow the positionFixed prop to be passed through to the Popper component

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #1473

Allow the positionFixed prop to be passed through to the Popper component

Fixes reactstrap#1473
@Maczuga
Copy link

Maczuga commented Jul 9, 2019

@TheSharpieOne can we have this merged? I've been using this pull request for a while, works without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DropdownMenu - positionFixed not working anymore since v8
3 participants