Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset disabled property not working #1546

Closed
BenevidesLecontes opened this issue Jun 25, 2019 · 2 comments · Fixed by #1547 · May be fixed by largerock/largerock.com#5
Closed

Fieldset disabled property not working #1546

BenevidesLecontes opened this issue Jun 25, 2019 · 2 comments · Fixed by #1547 · May be fixed by largerock/largerock.com#5
Labels

Comments

@BenevidesLecontes
Copy link

BenevidesLecontes commented Jun 25, 2019

  • components: FormGroup with tag fieldset
  • reactstrap version #8.0.0
  • import method umd/csj/es
  • react version #16.8.6
  • bootstrap version #4.3.1

What is happening?

Fieldset not receiving the disabled property as in the html specs

What should be happening?

Fieldset should be receiving the disabled property as in the html specs
https://www.w3schools.com/tags/att_fieldset_disabled.asp

TheSharpieOne added a commit that referenced this issue Jun 26, 2019
fieldset allows the disabled attribute and has special handling in the browser.
This change will allow the disabled prop to be passed through when the tag is a fieldset

fixes #1546
@TheSharpieOne
Copy link
Member

I've made a change so that when tag is "fieldset" it will pass the disabled prop down. Not sure if you are using tag="fieldset" or if you are using another component which eventually renders a fieldset. If it's the latter, then another change would have to be made, but would have larger implications.

@BenevidesLecontes
Copy link
Author

@TheSharpieOne I'm using <FormGroup tag="fieldset" />

TheSharpieOne added a commit that referenced this issue Jun 26, 2019
fieldset allows the disabled attribute and has special handling in the browser.
This change will allow the disabled prop to be passed through when the tag is a fieldset

fixes #1546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment