Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(issue#1255-unmounted-tooltip) #1562

Merged
merged 1 commit into from Jul 8, 2019
Merged

fix:(issue#1255-unmounted-tooltip) #1562

merged 1 commit into from Jul 8, 2019

Conversation

jinixx
Copy link
Contributor

@jinixx jinixx commented Jul 8, 2019 •
edited

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes: #1255

@jinixx jinixx changed the title fixed React state update on an unmounted component error fix:(issue#1255-unmounted-tooltip) Jul 8, 2019
@jinixx jinixx mentioned this pull request Jul 8, 2019
Closed
TheSharpieOne
TheSharpieOne approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@TheSharpieOne TheSharpieOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tracking _isMounted is really needed as long as the timeouts are being cleared... but, eh it doesn't really matter.

@TheSharpieOne TheSharpieOne merged commit e85238b into reactstrap:master Jul 8, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle called from unmounted Tooltips
2 participants
@jinixx @TheSharpieOne