fix: Dropdown disabled toggle issue

[bpas247]

• Bug fix
• New feature
• Chore
• Breaking change
• There is an open issue which this change addresses
• [xI have read the CONTRIBUTING document.
• My commits follow the Git Commit Guidelines
• My code follows the code style of this project.
• My change requires a change to the documentation.
• • I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

This fix addresses the issue where Dropdown will be passed a
disabled prop, yet it is still clickable. This is due to context
being passed the user-defined toggle prop directly, rather than
our defined this.toggle function that includes a check for
disabled.

Fixes #1542

[bpas247]

hmm, I'm not exactly sure why those tests are failing, they seem unrelated to the changes I committed.

Anyone have any ideas what could be causing this?

[TheSharpieOne]

I think you found some bad tests. It looks like it was expecting the Dropdown toggle to not be called... when it should have been getting called. Since you fixed it to call Dropdown's toggle (which in turn calls the user's toggle), those tests fail.

In reality, those tests probably should have been failing this whole time and this PR would have make them pass.

Can you change expect(Dropdown.prototype.toggle.mock.calls.length).toBe(0); to expect(Dropdown.prototype.toggle.mock.calls.length).toBe(1); in both of those tests to get them to pass as they should be expecting Dropdown's toggle to be called 1 time.

[bpas247]

Can you change expect(Dropdown.prototype.toggle.mock.calls.length).toBe(0); to expect(Dropdown.prototype.toggle.mock.calls.length).toBe(1); in both of those tests to get them to pass as they should be expecting Dropdown's toggle to be called 1 time.

I had a feeling they were wrong 😉 will do 👍