fix(Carousel): ie11 compatibility changes(#799) #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the CustomEvent polyfill recommended in the MDN web docs (https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent#Polyfill). This also applies a simple polyfill for Object.values I found in the react-transition-group module (https://github.com/reactjs/react-transition-group/blob/9e3b2d3c09b78e755bdc837b7b38337812ede2c9/src/TransitionGroup.js#L11). Fixes reactstrap#799
nathanbacon
changed the title
TheSharpieOne
changed the title
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the Carousel component has CarouselIndicators, it crashes upon transition in IE11 per #799. This PR polyfills CustomEvent and Object.values (not mentioned in #799 but necessary for CarouselIndicators). It'd be nice to fix this component, since it's expected to work in vanilla bootstrap, down to IE10.