New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel needs to push a href prop #1631
Carousel needs to push a href prop #1631
Comments
Hey. I can take this |
https://webaim.org/techniques/hypertext/
things like Because of this, I would not hard-code |
The pointer effect can simply be achieved with CSS/styling. Addition of hypertext in this case is not even needed as the carousel itself works fine by navigating to the next and previous images. I'm adding the code for this |
@TheSharpieOne pushed a PR for this. Please take a look 🙂 |
8.0.1
es
16.9.0
4.3.1
What is happening?
The next and previous control are working correctly, but are NOT showing the "pointer" cursor when you mouse hover
What should be happening?
It should show a "pointer" cursor when you hover over the next and previous controls.
Steps to reproduce issue
Go to the reactstrap documentation and hover over the previous and next buttons. Notice how it doesn't show a pointer cursor.
https://reactstrap.github.io/components/carousel/
Go to the React Bootstrap documentation and hover over the previous and next button. It does have a pointer cursor. It achieves this simply by adding a href="#" attribute in the generated code.
https://react-bootstrap.github.io/components/carousel/
Go to the Bootstrap documentation. They achieve the same pointer cursor by simply adding a href="#" in the html code.
https://getbootstrap.com/docs/4.3/components/carousel/#with-controls
The text was updated successfully, but these errors were encountered: