New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavbarToggler Accessibility #1632
Closed
TheSharpieOne opened this issue
Sep 25, 2019
· 1 comment
· Fixed by #1633 · May be fixed by largerock/largerock.com#5
Closed
NavbarToggler Accessibility #1632
TheSharpieOne opened this issue
Sep 25, 2019
· 1 comment
· Fixed by #1633 · May be fixed by largerock/largerock.com#5
Comments
Hey I'd like to pick this up. Will raise a PR in a while after I'm done! |
glenpadua
pushed a commit
to glenpadua/reactstrap
that referenced
this issue
Sep 26, 2019
This adds the aria-label to the NavbarToggler as seen in the bootstrap docs. Fixes reactstrap#1632
12 tasks
glenpadua
pushed a commit
to glenpadua/reactstrap
that referenced
this issue
Sep 26, 2019
This adds the aria-label to the NavbarToggler as seen in the bootstrap docs. Fixes reactstrap#1632 Fix breaking tests
glenpadua
pushed a commit
to glenpadua/reactstrap
that referenced
this issue
Sep 27, 2019
This adds the aria-label to the NavbarToggler as seen in the bootstrap docs. Fixes reactstrap#1632 Fix breaking tests Change order of aria prop to allow overrides
TheSharpieOne
pushed a commit
that referenced
this issue
Sep 28, 2019
This adds the aria-label to the NavbarToggler as seen in the bootstrap docs. Fixes #1632 Fix breaking tests Change order of aria prop to allow overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
reactstrap should add the
aria-label="Toggle navigation"
as seen in bootstrap's docs. It would be overridable by the props passed in.reactstrap should also include information about the
aria-controls
andaria-expanded
for additional a11y as those would need to be provided by the user (NavbarToggler
doesn't actually know if it is toggled or not (maybe it could/should?))The text was updated successfully, but these errors were encountered: