Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NavbarToggler): add aria-label to NavbarToggler #1633

Merged
merged 1 commit into from Sep 28, 2019

Conversation

glenpadua
Copy link
Contributor

@glenpadua glenpadua commented Sep 26, 2019

This adds the aria-label to the NavbarToggler as
seen in the bootstrap docs.

Fixes #1632

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@glenpadua
Copy link
Contributor Author

Working on the breaking tests.

@@ -31,7 +31,7 @@ const NavbarToggler = (props) => {
), cssModule);

return (
<Tag {...attributes} className={classes}>
<Tag {...attributes} className={classes} aria-label="Toggle navigation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would place it before {...attributes} so that the attributes can override it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Done 👍

This adds the aria-label to the NavbarToggler as
seen in the bootstrap docs.

Fixes reactstrap#1632

Fix breaking tests

Change order of aria prop to allow overrides
@TheSharpieOne TheSharpieOne merged commit dc0b8ae into reactstrap:master Sep 28, 2019
@macsplan
Copy link

hi @TheSharpieOne any ideas when's this getting to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavbarToggler Accessibility
4 participants