PopperContent memory leak #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining element When a tooltip or popover does not fit in the containing element, this causes the `PopperContent` component to get into an infinite loop of switching between `placement`s in its state. This is because we attempt to update `this.state.placement` everytime popper.js flips the placement to find a better fit and pass it back as the `placement` property to `ReactPopper`. This is a problem because the `PopperContent` component has two sources of truth for its placement. One coming from its own `placement` property, and one coming from the internal data of `ReactPopper`. This commit fixes the issue by using `PopperContent`'s `placement` property as the initial placement of the `ReactPopper` component and allowing `ReactPopper` to manage its own updates (i.e. if the popover needs to be flipped because there's not enough room for the specified placement.) Fixes reactstrap#1482 Fixes reactstrap#1488
phwebi
commented
Oct 17, 2019
| const popperClassName = mapToCssModules(classNames( | ||
| _popperClassName, | ||
| placementPrefix ? `${placementPrefix}-${placementFirstPart}` : placementFirstPart | ||
| placementPrefix ? `${placementPrefix}-auto` : '' |
There was a problem hiding this comment.
This allows the arrow to inherit its style from the computed popper placement instead of the placement property passed into this component.
phwebi
added a commit
to phwebi/reactstrap
that referenced
this pull request
Oct 18, 2019
I accidentally left a debug statement in reactstrap#1669 that was merged. This commit removes the debug statement.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tooltip or popover does not fit in the containing element, this causes the
PopperContentcomponent to get into an infinite loop of switching betweenplacements in its state. This is because we attempt to updatethis.state.placementeverytime popper.js flips the placement to find a better fit and pass it back as theplacementproperty toReactPopper.This is a problem because the
PopperContentcomponent has two sources of truth for its placement. One coming from its ownplacementproperty, and one coming from the internal data ofReactPopper.This commit fixes the issue by using
PopperContent'splacementproperty as the initial placement of theReactPoppercomponent and allowingReactPopperto manage its own updates (i.e. if the popover needs to be flipped because there's not enough room for the specified placement.)I manually tested this by reproducing the issues linked below at https://reactstrap.github.io/components/popovers/, and making sure that the page wouldn't crash when I followed the same steps on the changes in this branch.
Fixes #1482
Fixes #1488
Fixes #1664