Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying the hidden attribute to CustomInput #1741

Closed
ainslie1171 opened this issue Jan 8, 2020 · 1 comment
Closed

Applying the hidden attribute to CustomInput #1741

ainslie1171 opened this issue Jan 8, 2020 · 1 comment

Comments

@ainslie1171
Copy link

Issue description

  • components: CustomInput
  • reactstrap version #8.2.0
  • react version #16.12.0
  • bootstrap version #4.4.1

What is happening/What should be happening?

When a CustomInput component is given the hidden attribute you get different behavior based on the type. Types range and select work as expected, however, checkbox, file, radio and switch are all still shown when the hidden attribute is applied to the CustomInput component. The hidden attribute is being passed on to the Input element in all cases but I think due to the offending types being wrapped in divs, the effect of the hidden attribute is being negated and in those instances, it needs to instead be applied to the div to get the same effect for all types.

TheSharpieOne pushed a commit that referenced this issue Jan 31, 2020
* Investigation

* Fix for custom input hidden attr

* Updated CustomFileInput to output hidden attr

* fix(CustomInput): Input hidden whitespace

* fix(CustomInput): Hidden attr import quotes
@TheSharpieOne
Copy link
Member

closed via bb39b55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants