Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the modal using Esc button when keyboard={true} and backdrop="static" #1766

Closed
TheSharpieOne opened this issue Jan 22, 2020 · 2 comments · Fixed by #1767 or #1770 · May be fixed by largerock/largerock.com#5
Closed

Close the modal using Esc button when keyboard={true} and backdrop="static" #1766

TheSharpieOne opened this issue Jan 22, 2020 · 2 comments · Fixed by #1767 or #1770 · May be fixed by largerock/largerock.com#5
Assignees
@kyletsang

Comments

@TheSharpieOne
Copy link
Member

The behavior was changed since version 4.2.0: before I was able to close the modal using Esc button when keyboard={true} and backdrop="static", but now I can't. Is it expected?

Originally posted by @ALEUT in #1750 (comment)

Also reference: twbs/bootstrap#29978
@kyletsang
Copy link
Member

The bootstrap bug fix was made post-4.4.1. I'll take this one if you haven't already @TheSharpieOne

@TheSharpieOne
Copy link
Member Author

@kyletsang all your 👍

@kyletsang kyletsang mentioned this issue Jan 22, 2020
Merged
12 tasks
TheSharpieOne pushed a commit that referenced this issue Jan 27, 2020
@kyletsang @TheSharpieOne
fix(Modal): Allow esc to close static backdrop modal when keybo… (#1767)
49da7b5 
Fixes #1766
@TheSharpieOne TheSharpieOne mentioned this issue Jan 27, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 9, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 20, 2020
Closed
@github-actions github-actions bot mentioned this issue Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this issue May 13, 2023
Merged
@github-actions github-actions bot mentioned this issue Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyletsang kyletsang

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TheSharpieOne @kyletsang