Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.find not supported in IE 11 #1774

Closed
stranzhay opened this issue Jan 29, 2020 · 1 comment · Fixed by #1776 or #1854 · May be fixed by #2788
Closed

.find not supported in IE 11 #1774

stranzhay opened this issue Jan 29, 2020 · 1 comment · Fixed by #1776 or #1854 · May be fixed by #2788
Assignees
@stranzhay
Labels
bug in-progress

Comments

@stranzhay
Copy link
Contributor

  • reactstrap version #8.4.1
  • react version #16.3.2

What is happening?

In IE11, Array.prototype.find throws a console error here:

reactstrap/src/TooltipPopoverWrapper.js

Line 65 in 80bd3e2

return subtreeRoots && subtreeRoots.length && subtreeRoots.find(subTreeRoot=> isInDOMSubtree(element, subTreeRoot));

Error message in console

Object doesn't support property or method 'find'

Suggested solution

Use Array.prototype.filter instead
@stranzhay
Copy link
Contributor Author

I will go ahead and fix this one.

@stranzhay stranzhay mentioned this issue Jan 30, 2020
Merged
12 tasks
TheSharpieOne pushed a commit that referenced this issue Jan 31, 2020
@stranzhay
fix(TooltipPopoverWrapper): replacing find with filter to preve… (#1776)
54648b6 
* feat(TooltipPopoverWrapper): replacing find with filter to prevent console error in IE 11

* chore(TooltipPopoverWrapper): undoing formatting from prettier

Fixes #1774
@TheSharpieOne TheSharpieOne mentioned this issue Jun 23, 2020
Merged
@github-actions github-actions bot mentioned this issue Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this issue May 13, 2023
Merged
@github-actions github-actions bot mentioned this issue Jun 9, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this issue Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stranzhay stranzhay

Labels
bug in-progress
Projects
None yet
Milestone
No milestone
2 participants
@TheSharpieOne @stranzhay