Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Progress): add aria props (#1681) #1787

Merged

Conversation

yogmel
Copy link
Contributor

@yogmel yogmel commented Feb 13, 2020

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR passes aria-valuetext and aria-labelledby to Progress component.
It also set default min value, allowing users to set custom min prop.

#1681

pass aria-valuetext , aria-labelledby to Progress. Set default min value.
@yogmel
Copy link
Contributor Author

yogmel commented Feb 13, 2020

@TheSharpieOne Thanks for allowing me to work on this and sorry I took so long to open a PR.
I have read the issue and identified these tasks, but maybe there was more to be done. Please let me know.
Also, I'm not sure who should be the reviewer, so I requested your revision.

@TheSharpieOne TheSharpieOne changed the title Progress: add aria props (#1681) feat(Progress): add aria props (#1681) Jun 22, 2020
@TheSharpieOne TheSharpieOne merged commit 93f171d into reactstrap:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants