Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TooltipPopoverWrapper): scheduleUpdate as render prop #1792

Merged
merged 3 commits into from Jun 22, 2020
Merged

feat(TooltipPopoverWrapper): scheduleUpdate as render prop #1792

merged 3 commits into from Jun 22, 2020

Conversation

kyletsang
Copy link
Member

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Resolves #1744 and #1737.

This PR exposes the PopperJS scheduleUpdate function so users can manually call it to reposition the popper as needed.

@jrozbicki
Copy link

Looks great! Looking forward to have it merged in 🎉

@TheSharpieOne TheSharpieOne changed the title feat(TooltipPopoverWrapper): Expose scheduleUpdate as render prop feat(TooltipPopoverWrapper): scheduleUpdate as render prop Jun 22, 2020
@TheSharpieOne TheSharpieOne merged commit cda6fe9 into reactstrap:master Jun 22, 2020
@TheSharpieOne TheSharpieOne mentioned this pull request Jun 23, 2020
Merged
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popover schedule update
3 participants
@kyletsang @jrozbicki @TheSharpieOne