Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-out-of-boundaries attribute to popover #1835

Closed
khanilov opened this issue May 12, 2020 · 3 comments · Fixed by #1836 or #1854 · May be fixed by #2788
Closed

Add x-out-of-boundaries attribute to popover #1835

khanilov opened this issue May 12, 2020 · 3 comments · Fixed by #1836 or #1854 · May be fixed by #2788

Comments

@khanilov
Copy link
Contributor

  • components: PopperContent
  • reactstrap version ^8.4.1
  • import method es
  • react version ^16.8.6
  • bootstrap version ^4.3.1

What is happening?

Popper hide modifier has no effect on rendered popover.

What should be happening?

Add x-out-of-boundaries attribute for div rendered by ReactPopper when outOfBoundaries field in render prop argument is true.

outOfBoundaries is passed to render prop function by ReactPopper, but not used in PopperContent component.

Proofs:
https://github.com/popperjs/react-popper/blob/v1.3.6/src/Popper.js#L208-L218
https://github.com/reactstrap/reactstrap/blob/master/src/PopperContent.js#L149-L160

Motivation behind x-out-of-boundaries: https://github.com/reactstrap/reactstrap/blob/master/src/PopperContent.js#L149-L160

@sirldev
Copy link

sirldev commented May 22, 2020

Hi!
Is this reason of why Popover Placements left doesn't work at here?

@khanilov
Copy link
Contributor Author

@JunHyeokHa
Hi.
Don't think so, I haven't touched placement in my PR.
Also this changes hasn't been released yet.

@sirldev
Copy link

sirldev commented May 25, 2020

@khanilov
Oh I see.
Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants