Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing window causing NextJS builds to fail #1855

Merged
merged 1 commit into from Jun 24, 2020
Merged

Fix missing window causing NextJS builds to fail #1855

merged 1 commit into from Jun 24, 2020

Conversation

justinbrumley
Copy link
Contributor

@justinbrumley justinbrumley commented Jun 23, 2020

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #1857

@iamandrewluca iamandrewluca merged commit 74b6802 into reactstrap:master Jun 24, 2020
@iamandrewluca
Copy link
Contributor

@justinbrumley Thanks!

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Jun 24, 2020

@TheSharpieOne can we have a patch release on this one?
People start to open issues related to this.

@viswassaripalli
Copy link

is it released or what is the ETA of the release. its creating an issue on my production build. please reply quick

@iamandrewluca
Copy link
Contributor

A quick workaround is to downgrade to previous version.

@mverderese
Copy link

Thanks for getting the fix out so quickly. I just downgrade to 8.3.2 to fix this issue for now. Can you please post on this thread when 8.5.1 is release with this patch?

@iamandrewluca
Copy link
Contributor

Yes

@mrassili
Copy link

mrassili commented Jun 24, 2020

@iamandrewluca thanks for the quick fix, is 8.5.1 going to be released any soon?

EDIT: Thanks to @justinbrumley for the fix

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Jun 24, 2020

Thanks @justinbrumley for the fix. I don't have permissions to release a new version. @TheSharpieOne can, but I think he is pretty busy.

@TheSharpieOne
Copy link
Member

@iamandrewluca you should be able to create the release, I sent you an email with more details. I want to make sure you are able to create a release in case I am not. So give it a try with this one and let me know if you have any trouble.

@iamandrewluca
Copy link
Contributor

Ok.

@iamandrewluca
Copy link
Contributor

Fixed in https://github.com/reactstrap/reactstrap/releases/tag/8.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reactstrap 8.5.0, next.js window not defined
6 participants