Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to apply custom height to Progress #2071

Closed
vhenzl opened this issue Jan 11, 2021 · 1 comment · Fixed by #2075
Closed

Not possible to apply custom height to Progress #2071

vhenzl opened this issue Jan 11, 2021 · 1 comment · Fixed by #2075
Labels

Comments

@vhenzl
Copy link

vhenzl commented Jan 11, 2021

  • components: Progress
  • reactstrap version 8.8.1 (since 8.5.0)
  • import method - irrelevant
  • react version 16.14
  • bootstrap version 4.5.3

What is happening?

It's not possible to apply custom height to Progress component as style prop is applied to the inner progress-bar element instead of the root progress element.

image

It's broken since 8.5.0 (likely because of #1771). Seems like #1970 in 8.7.0 tried to fix that but it didn't.

What should be happening?

It should be possible to specify height with CSS styles as per Bootstrap doc:

<div class="progress" style="height: 1px;">
  <div class="progress-bar" style="width: 25%;"></div>
</div>

The above should be equivalent to:

<Progress value={25} style={{ height: "1px" }} />

Steps to reproduce issue

https://codesandbox.io/s/reactstrap-progress-bug-tuqb1?file=/src/App.js

@kyletsang
Copy link
Member

We should revert #1771 and expose a progressStyle prop or something to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants