You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed missing close prop on OffcanvasHeader. When looked at source code of the types and comparing with the propTypes in JS file noticed that also closeAriaLabel is missing from the types.
I've checked and the very same thing is with ModalHeader component.
This means that there is no hint provided:
What should be happening?
The type should contain missing props
// ~PropsWithChildren will add a children prop~ - actually HTMLAttributes handles that :)
export interface OffcanvasHeaderProps extends React.HTMLAttributes<HTMLElement> {
[key: string]: any; // is it needed?
tag?: React.ElementType;
close?: React.ReactNode;
closeAriaLabel?: string;
cssModule?: CSSModule;
wrapTag?: React.ElementType;
toggle?: React.MouseEventHandler<any>;
}
hint should prompt with valid type
Steps to reproduce issue
Add in typescript code, try to type close property, expected hint will not appear.
Error message in console
None
Code
N/A
The text was updated successfully, but these errors were encountered:
OffcanvasHeader
#x.x.x
es
#18.2.0
#5.3.3
What is happening?
I've noticed missing
close
prop onOffcanvasHeader
. When looked at source code of the types and comparing with the propTypes in JS file noticed that alsocloseAriaLabel
is missing from the types.I've checked and the very same thing is with ModalHeader component.
This means that there is no hint provided:
What should be happening?
The type should contain missing props
hint should prompt with valid type
Steps to reproduce issue
Add in typescript code, try to type
close
property, expected hint will not appear.Error message in console
None
Code
N/A
The text was updated successfully, but these errors were encountered: