Should we release 0.73.4?

[blakef]

Current Release: 0.73.4

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

Local commits to backport to main

[dmytrorykun]

facebook/react-native#42586 to fix facebook/react-native#42477 (the Unsupported top level event type "topAnimationFinish" dispatched error).

[lunaleaps]

✅ picked

[cortinico]

I'd like to have this commit picked:

• facebook/react-native@ca9b6b5

This suppresses a warning we're seeing with react-native-screens and Bridgeless Mode in 0.73 (cc @WoLewicki)

[lunaleaps]

✅ picked

[cipolleschi]

Please merge facebook/react-native#42734 as it definitely fixes a concurrency issue and solve a runtime warning. The PR is already against 0.73 branch.

[lunaleaps]

✅ merged

[vksgautam1986]

@here https://react-native-community.github.io/upgrade-helper/ is still showing 0.72.2 as latest version to update, can we update it to 0.73.3

[lunaleaps]

I'm guessing you mean 0.73.2 and when I go to the upgrade-helper now the latest version is 0.73.3

[vksgautam1986]

yeah sorry i means 0.73.2, now its working fine. thanks

[blakef]

Sorry, I fixed that. @lunaleaps should we be commenting on here when resolved?

[gituser8796]

Could you please include an important performance fix for Hermes JSON.stringify?

facebook/hermes@8fd20f2

#98 (comment)

[lunaleaps]

See my comment on the disussion: #98 (reply in thread)

I don't think this should be going in

[lunaleaps]

Update:

I have picked and merged all relevant changes for 0.73.4
Things we still need to do

1. Run bump as there are changes to react-native-codegen
2. Run two series of testing for 0.73.4

For 1., I'm not running bump yet as it actually publishes the package and its the weekend and I don't want to leave things in an intermediate state. I'll ping the release oncall folks and see who can volunteer to do the first round of testing. They can run the bump

For 2., I can run the second round of testing and release 0.73.4

Note: We should validate that this fix at minimum - facebook/react-native#42734