Should we release 0.73.5?

[lunaleaps]

Current Release: 0.73.4

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

All qualified picks have been made. See latest status comment.

[msageryd]

I'm not sure of how this works regarding branches. The commit I think should be picked is already merged into main, but I suppose main is not the same as the next release branch?

There are many issue-numbers involved and I don't know which to link here. I'll link the commit instead:
facebook/react-native@c684f9f

This is a simple and risk-free fix that will make live much easier for those who use NVM or other Node version managers and does not have a regular Node installed.

[lunaleaps]

✅ picked

[cwhenderson20]

Can we pick facebook/hermes@e7b2abe to fix a WeakMap memory leak in Hermes? Was confirmed safe for 0.73 here.

[lunaleaps]

✅ picked

[tido64]

There is a regression in 0.73 that prevents repos using pnpm from running any react-native command. We should cherry-pick the fix for it: facebook/react-native@8f4f09b

[lunaleaps]

We are aiming to release 0.73.5 on 02/20/2024

[lunaleaps]

✅ picked

[gituser8796]

Could you please include an important performance fix for Hermes JSON.stringify? @lunaleaps it was committed into main branch:

facebook/hermes@6286470

[lunaleaps]

✅ picked.

As an FYI, we ended up already committing the pick to the rn/0.73 branch from the static-hermes branch. I tried cp-ing this commit and there was no change. Instead of reverting and cp-ing this, I'm keeping the original pick and verified they are identical

[lunaleaps]

This has already been requested.

[lunaleaps]

This is a new capability. It will be in 0.74

[tido64]

Codegen in 0.73 fails to find third-party libraries (both Yarn and pnpm setups are affected): facebook/react-native#42943

This is already a PR on 0.73-stable. The scripts have changed significantly on main.

[lunaleaps]

✅ merged

[lunaleaps]

Status update:

As of now, we won't be accepting any more pick requests. The outstanding issue is that the 0.73 Hermes branch has red CI and I'm following up internally to see how we should address.

Once I get an answer for that, will need to release a new Hermes tag and then bump the monorepo packages and test.

[cipolleschi]

Please pick:

• [RN][iOS] Fix compiler flags passed to libraries facebook/react-native#43088
  This is a pretty important fix as all the libraries that are using this function provided by React Native might suffer from problems when the New architecture is turned on.

[normtronics]

Please add:

• Fix RCTFabric podspec facebook/react-native#42639

After trying to upgrade our builds are now failing in CircleCi. See image below.

[lunaleaps]

I can't cleanly pick this -- @cipolleschi can you make a PR against 0.73 for this?

[lunaleaps]

@cipolleschi Here is how I ended up resolving: facebook/react-native@0061bea

[cipolleschi]

Thanks @lunaleaps for cherry picking this. The conflict resolution seems correct.

[fabOnReact]

Please pick

facebook/react-native@349d550

Adding paragraphStyle.maximumLineHeight to a iOS UITextField displays the text under the UITextField (ios-screenshot-1, ios-screenshot-2, ios-screenshot-3). PR #38359 fixes the issue.

[lunaleaps]

See #103 (comment)

Okay I'll make the exception this case because we had other fixes to pick. Next time, please respect the pick deadline. We can try to be more clear about that.

[NickGerleman]

We should pick facebook/react-native@e33767a to workaround a commonly reported Babel misconfiguration.

Edit: just saw the comment about the pick deadline. If we end up doing another 0.73 release, I think this would meaningfully reduce issues reported and PRs trying to fix.

[lunaleaps]

Yup it's on Github releases now

[lunaleaps]

This is not the discussion space for issues for 0.73. Please file an issue on react-native repo instead