Should we release 0.73.2?

[huntie]

Released, please refer to #98

Current Release: 0.73.1

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

[huntie]

To cherry pick (carried over from #94):

• facebook/react-native@1a0e174

[cortinico]

This is not needed anymore as it has been closed 👍

[cipolleschi]

CircleCI got broken yesterday due to Ruby and bundler. This is the fix:
facebook/react-native@479b4bb

[lunaleaps]

✅ merged

[axinvd]

Android border platformcolor fix
Already included in 0.72.7, but not present in 73.x
facebook/react-native@265af22

[huntie]

Picked ✅

[lunaleaps]

We need to delete the relevant translation folders that breaks deploying to Play store.
facebook/react-native#42024
@NickGerleman has fixed main to exclude this from being included on main

[lunaleaps]

facebook/react-native#42040, pending to see if @NickGerleman does more clean-up via an allow-list vs. just these two problematic translations

[lunaleaps]

✅ I've just merged this for now, we can delete more later as identified

[cortinico]

There are a couple of minor fixes that are needed to be picked in 0.73.2:

• Fix comment about adding packages in android template facebook/react-native#41856
• Enhance IP address retrieval for iOS devices in Metro bundler setup facebook/react-native#41839

[huntie]

Picked ✅

[cipolleschi]

Can we pick: facebook/react-native@1e5e3b5?

[fortmarek]

Picked ✅

[cortinico]

Nope this is not the right place. Please reach out to the library maintainer directly

[lunaleaps]

Two things that are slightly related:

1. Fix monorepo package versions to version published with release facebook/react-native#41958 -- Remove the rest of the ^ in our monorepo deps. This is causing problems because all monorepo dep versions are <1.0 which means ~ and ^ behave the same way and when we have something like ^0.72.2 in our package.json, and we publish0.73.0, people will pull that one in erroneously.
2. Update these to use latest 0.73.x versions facebook/react-native#42082 -- We want to remove * dependencies for our monorepo deps as this will cause similar issues to 1. We fix these to the latest published versions.

Both of these changes have also been made on main.

[lunaleaps]

✅ I've merged both of these

[cipolleschi]

Can we merge: facebook/react-native#42087
This should fix iOS CI for e2e tests

[lunaleaps]

✅ merged

[mmmoussa]

In the release blog for 0.73 it was stated that 0.73 would be the last RN version to support Android SDK 21. However, 0.73 was released with a change that breaks usage below Android SDK 23. That commit should be reverted in 0.73.2.

[cortinico]

That's definitely a problem and should be reverted/addressed. cc @mdvacca aslo

[huntie]

Reverted ✅

[cortinico]

@huntie small heads up that I don't think we can simply revert this. There should probably be a fix forward which I'd like to discuss with @mdvacca

[mdvacca]

After analyzing this with @cortinico, we concluded that:

• facebook/react-native@1904e80 was incorrectly picked into RC, so is ok to just revert it.
• we have to make sure facebook/react-native@45dce98 is actually in the 0.73 (this was the correct diff to pick into 0.73)

cc: @huntie

[huntie]

@mdvacca @cortinico Thanks, actioned ✅

[jacobp100]

Can we get facebook/react-native@d6163d7 ?

[huntie]

Picked ✅

[joe-sam]

Corrects LogBox to display the actual stack trace libraries instead of internal code on the debug thread for all custom errors during unhandled promises.
facebook/react-native#42079

[huntie]

Picked ✅

[sagarj-iprogrammer]

can we pick
facebook/react-native#36710
@huntie same issue with RN0.73.1

[NickGerleman]

Could we pick facebook/react-native@e809e0a to fix RTL scrollTo issue on iOS?

[huntie]

Picked ✅

[vikrambatra08]

Can we pick - facebook/react-native#34400 ?

[liamjones]

I believe Vikram means this commit specifically: facebook/react-native@bab9c83

[huntie]

@cortinico @cipolleschi Are we happy to bump SocketRocket on both platforms?

[liamjones]

@huntie Sorry, I should've looked at the PR before suggesting Vikram add a pick request here. Looking back at the original PR it looks like @cipolleschi already said it'd have to wait until Flipper is gone (0.74) because of issues with the update + Flipper on Android: facebook/react-native#39571 (comment) & facebook/react-native#39571 (comment)

[kelset]

also I don't think we'd want to bump between majors (0.6.x -> 0.7.x) on a patch release (which is why it even the commit body mentions that it would have been only viable to pick up in 0.73 before 0.73.0)