Should we release 0.73.3?

[fortmarek]

Current Release: 0.73.2

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

[gituser8796]

Could you please include an important performance fix for Hermes JSON.stringify?

facebook/hermes@8fd20f2

[neildhar]

@lunaleaps Good catch, it looks like we only made this change in Static Hermes, given that, I'd avoid picking it.

@blakef Our CI currently just pulls from trunk. It's possible to extend it to allow setting a specific RN version, although the e2e test that pulls RN is very simple, and is unlikely to add any value over the testing done on the RN side.

[gituser8796]

@neildhar would it be possible to get this on the main branch? We notice a significant performance hit on our app due to this issue. Any help here would be appreciated!

[neildhar]

@gituser8796 This seems reasonable to put on our main branch, we'll port it over.

[gituser8796]

Thx @neildhar! How do we get it into 0.73.5? @lunaleaps

[lunaleaps]

@gituser8796 When the commit is on main, please make a pick request on the latest stable.

[wfern]

To fix a release build error due to a casing issue in hermes tarball path

facebook/react-native@2e2f8a6

[blakef]

✅ Picked

[cipolleschi]

Fix for symbol not found _jump_fcontext with use_frameworks! (#39945):

• [RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! facebook/react-native#42227

[blakef]

✅ Picked @ merge.

[tido64]

This is a fix needed for pnpm setups: facebook/react-native@9155e2d

[blakef]

✅ Picked

[Crhaj]

Could we please consider these 2 fixes which should resolve long term issue with Touchable* stopping to fire onPress events?

• facebook/react-native@e4708d6
• facebook/react-native@5416634

[the-skins-app]

Would definitely appreciate this as well.

[blakef]

✅ Picked

[GorbunovV]

Picked

[idrissakhi]

Would you please include this fix to resolve Image resolving issue on tests (Jest tests)

• fix: image mock in jest setup facebook/react-native#41957

[blakef]

This change hasn't been accepted at the time we're cutting.

[szymonrybczak]

CLI Update - fixes running run-android command on Windows, and replacing packageName in new Kotlin template: facebook/react-native#42279

[blakef]

✅ Picked @ merge by @huntie.

[cipolleschi]

Please pick facebook/react-native@63e893d to fix an Xcode issue

[blakef]

✅ Picked

[cipolleschi]

Please pick facebook/react-native#42382
This fixes the podfile.lock and resolve a deadlock that prevent the apps from working in Release mode when the new architecture is enabled.

[cipolleschi]

but this PR that I just opened, should @migueldaipre.
Could you try to pick it and give it a shot?

It for sure fixes the crash, but I'm not sure about the expected behavior in a complex scenario.

The technical reasons is that:

• a refresh is invalidating the bridge
• an event is sent
• RCTDeviceInfo (which was not invalidated) reacts to the event
• being the bridge invalidated, some pieces are still missing ==> crash.

With the fix, we properly invalidate the RCTDeviceInfo, but it could be that by doing that we drop some events.

If you could try the patch in your repro and can report whether everything seems to look fine or not, it would be greatly appreciated!

Note: the PR is against main. If it fixes, we might be able to cherry pick the fix in 0.73.3

cc. @gabrieldonadel, you might be interested in trying out the fix as well. And infinite thanks for the repro! 🙏

[migueldaipre]

For me didn't work and the same crash still occurs.
I also tested both PRs together, with no news

Should I do more than just create a patch package and run the application?

[cipolleschi]

@migueldaipre thanks for the report. In theory a patch-package should be enough. The PR fixes the behavior reported by Gabriel. Could it be that your problem is different? It might be that we have other Modules that are not invalidated as expected and a colleague is investigating that.

If you can provide a reproducer starting from this repo it would speed up our work dramatically.

[gabrieldonadel]

Thanks for fixing this @cipolleschi, I just tested your PR and now everything is working as expected

[blakef]

✅ Picked @ merge.

[matinzd]

Please pick facebook/react-native@96ed119

This fixes the issue regarding the permission contracts on Android 14. 
Currently it’s blocking matinzd/react-native-health-connect#60 and anything related to this matter.

[blakef]

✅ Picked

[dmytrorykun]

facebook/react-native#40860 to address facebook/react-native#42477

[blakef]

✅ Picked

[cipolleschi]

We should pick facebook/react-native@d46d80d to fix an issue with reload.

[blakef]

✅ Picked

[gabrieldonadel]

Can we pick facebook/react-native#42637 when it gets merged? This will fix the unexpected changes on Info.plist when building on CI

[gabrieldonadel]

This is the commit facebook/react-native@41c601e

[blakef]

✅ Picked

[blakef]

Request picking facebook/react-native#42306 which resolves a crash.

[blakef]

✅ Picked

[cipolleschi]

This commit is pretty important and was lying in main since October.
Can we pick it in 0.73.3? 🙏

[blakef]

✅ Picked

[blakef]

We should pick facebook/react-native@3869ae4 when it lands to fix a Cocoapods issue.

[blakef]

✅ Picked

[efstathiosntonas]

@blakef any idea when 0.73.3 will be released? thanks

[blakef]

We're just testing everything now (because of the late picks), if we don't find any issues it should happen reasonably quickly. Can't be more specific than that.