Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] eslint: Update @typescript-eslint monorepo to v7 & eslint-plugin-jest to v27 #194

Open
lluiscab opened this issue Apr 2, 2024 · 6 comments

Comments

@lluiscab
Copy link

lluiscab commented Apr 2, 2024

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native#43406

Description

Publishing @react-native/eslint-config@0.74.78 with the dependencies updated at facebook/react-native#43406 would resolve various issues that occur in monorepos that use / have multiple versions of @typescript-eslint packages in use by other eslint plugins & configs. This is currently the major roadblock in updating to @typescript-eslint@7 in our internal eslint config packages.

We for example, can't really update eslint-plugin-jest to 27.0.0 due to issues caused when both eslint-plugin-jest@27 and eslint-plugin-jest@26 are installed in the same monorepo

@cortinico
Copy link
Collaborator

I've discussed this internally with @robhogan and we've decided to don't pick this change on the 0.74 release branch, at least for now. The rationale is that this is a major version bump of a dependency.

Realistically, this could result in more warnings for the end users, so no real impact on the final apps. But at the same time, this pick request is coming really late in the stabilisation process of 0.74 (we're at RC7 which we expect to be the Golden RC) and we don't want to include major version bumps in the last RC.

@cortinico cortinico closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@lluiscab
Copy link
Author

lluiscab commented Apr 8, 2024

I'm not familiarized with the react-native release process, given that these changes are already in the react-native repository, what will be your first release in which they will be included? Do I need to open a pick request for any other versions? 0.75?

@cortinico
Copy link
Collaborator

I'm not familiarized with the react-native release process, given that these changes are already in the react-native repository, what will be your first release in which they will be included? Do I need to open a pick request for any other versions? 0.75?

They will be included automatically in 0.75 👍 There is no need to file a pick request

@huntie
Copy link
Member

huntie commented Apr 24, 2024

Intending to test + pick for 0.74.1.

@huntie huntie reopened this Apr 24, 2024
@cortinico
Copy link
Collaborator

Intending to test + pick for 0.74.1.

I believe we discussed to don't include this in 0.74 as they're a major version bump of a dependency. Are we changing our stance here?

@cortinico
Copy link
Collaborator

I believe we discussed to don't include this in 0.74 as they're a major version bump of a dependency. Are we changing our stance here?

@robhogan cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Inbox
Development

No branches or pull requests

3 participants