Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update release steps #275

Open
humitos opened this issue Mar 12, 2024 · 1 comment
Open

Docs: update release steps #275

humitos opened this issue Mar 12, 2024 · 1 comment
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Mar 12, 2024

We have our release process explained at

https://readthedocs-client.readthedocs.io/en/latest/releasing.html

However, with the introduction of wrangler in the community/corporate repositories via common/ submodule, we now require also:

  1. update NGINX_ADDONS_GITHUB_TAG: https://github.com/readthedocs/common/blob/main/dockerfiles/docker-compose.yml#L29
  2. update common/ submodule on community and commercial as well

To solve 2) in a more generic way, it would be good if we can make common/ submodule to always point to the latest commit in main branch. cc @stsewd do you know if this is possible?

@humitos humitos added the Improvement Minor improvement to code label Mar 12, 2024
@stsewd
Copy link
Member

stsewd commented Mar 12, 2024

it would be good if we can make common/ submodule to always point to the latest commit in main branch. cc @stsewd do you know if this is possible?

I don't think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
Status: Planned
Development

No branches or pull requests

2 participants