Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not inject any CSS #17

Open
oliviertassinari opened this issue Jul 8, 2020 · 1 comment
Open

Add option to not inject any CSS #17

oliviertassinari opened this issue Jul 8, 2020 · 1 comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@oliviertassinari
Copy link

oliviertassinari commented Jul 8, 2020

I have to increase specificity to 4 in order to override the styles. It should be 1 or 2 at most. And ideally, not CSS would be injected in the page.

@agjohnson
Copy link
Contributor

We're still deciding if we want to support ad placements without stylesheets. There are definitely some good use cases for this. However, we also need to ensure a consistent base experience for the ad placements.

For now, our immediate focus is on a consistent base experience, but we have talked about this as a future feature of the client.

Reducing the required specificity of rules could at least make restyling easier, which could be a separate way to go if we do not enable ad placements without styles.

For now, you could also use a rule with higher specificity, like an id attribute, on the top level placement element. That would at least save you some typing.

@agjohnson agjohnson added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants